Merged
Conversation
📝 Walkthrough전체 요약미션 카드 컴포넌트의 비리더 사용자를 위한 클릭 가능 여부 판별 로직을 확장하여, 기존 IN_PROGRESS 및 EVALUATION_COMPLETED 상태에 ENDED 상태를 추가했습니다. 변경 사항
추정 코드 리뷰 노력🎯 2 (단순) | ⏱️ ~10분 축하 시
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/card/mission-card.tsx (1)
178-202:⚠️ Potential issue | 🟡 Minor비리더 관련 인라인 주석이 수정 사항을 반영하지 않음.
이번 변경으로 비리더 +
ENDED케이스가 클릭 가능 분기로 이동했지만, 해당 분기의 주석들은 아직 이전 동작을 서술하고 있습니다.📝 주석 수정 제안
- // 클릭 가능한 카드 (리더: 진행중/평가완료, 비리더: 진행중/평가완료) + // 클릭 가능한 카드 (리더: 진행중/평가완료, 비리더: 진행중/제출마감/평가완료) if (clickable) {- // 클릭 불가능한 카드 (비리더: 진행예정/제출마감) + // 클릭 불가능한 카드 (비리더: 진행예정) return (🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/card/mission-card.tsx` around lines 178 - 202, The inline comment around the clickable branch no longer matches the code: the non-leader + ENDED case was moved into the clickable branch, but the surrounding comments still describe the previous behavior. Update the comments near the clickable conditional in mission-card.tsx (the block using clickable, handleSelectMission and rendering MissionCardContent) to accurately state that this branch now covers leader: 진행중/평가완료 and non-leader: 진행중/평가완료 plus ENDED (or whatever the ENDED status constant is), and adjust the subsequent comment before the non-clickable branch to reflect the reduced/non-clickable cases; keep references to clickable and handleSelectMission so reviewers can locate the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@src/components/card/mission-card.tsx`:
- Around line 178-202: The inline comment around the clickable branch no longer
matches the code: the non-leader + ENDED case was moved into the clickable
branch, but the surrounding comments still describe the previous behavior.
Update the comments near the clickable conditional in mission-card.tsx (the
block using clickable, handleSelectMission and rendering MissionCardContent) to
accurately state that this branch now covers leader: 진행중/평가완료 and non-leader:
진행중/평가완료 plus ENDED (or whatever the ENDED status constant is), and adjust the
subsequent comment before the non-clickable branch to reflect the
reduced/non-clickable cases; keep references to clickable and
handleSelectMission so reviewers can locate the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 연관된 이슈
☘️ 작업 내용
#395 와 동일
🍀 참고사항
스크린샷 (선택)
Summary by CodeRabbit
릴리스 노트